[v1.13] golangci: Enable errorlint #31796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
kind/backports
|
/test-backport-1.13 |
|
Backported #23983 to bump vagrant boxes used for runtime tests to Go 1.20, which is already used in v1.13 development. G0 1.20 added support for multiple |
|
/test-backport-1.13 Job 'Cilium-PR-K8s-1.21-kernel-4.19' hit: #30802 (89.99% similarity) |
sayboras
approved these changes
Apr 8, 2024
|
/test-1.21-4.19 |
|
/test-1.23-4.19 |
|
/test-1.24-5.4 |
|
/test-1.26-net-next |
|
/test-upstream-k8s |
|
/test-1.24-5.4 |
|
/test-1.26-net-next |
|
/test-1.24-5.4 |
squeed
approved these changes
Apr 15, 2024
glibsm
approved these changes
Apr 16, 2024
jrajahalme
force-pushed
the
fix-error-wrapping-1.13
branch
from
c96baf5
to
9616cee
Compare
|
rebased & resolved conflicts |
|
/test-backport-1.13 Job 'Cilium-PR-K8s-1.22-kernel-4.19' hit: #30802 (92.04% similarity) |
|
/test-runtime |
|
/test-1.24-5.4 |
|
/test-1.22-4.19 |
|
/test-backport-1.13 Job 'Cilium-PR-K8s-1.22-kernel-4.19' hit: #30802 (90.95% similarity) |
jrajahalme
force-pushed
the
fix-error-wrapping-1.13
branch
from
534db40
to
7edc45a
Compare
|
Added a commit to bump up VM provisioning timeouts |
|
/test-backport-1.13 |
michi-covalent
approved these changes
Apr 17, 2024
aditighag
added
the
dont-merge/needs-rebase
Build already uses Go 1.20, so lint for it. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
[ upstream commit d20f15e ] Enable errorlint in golangci-lint to catch uses of improper formatters for Go errors. This helps avoid unnecessary error/warning logs that cause CI flakes, when benign error cases are not caught due to failing error unwrapping when a string or value formatter has been used instead of the dedicated `%w`. Related: #31147 Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
[ upstream commit fe46958 ] Precede each `%w` formatter with a colon. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
[ upstream commit 197b763 ] The new box versions include Go 1.20.1 which is now required for development. Backporter note: 4.9 box was not updated. Signed-off-by: Tobias Klauser <tobias@cilium.io>
vagrant-ci-start.sh script in test-1.24-5.4 jenkins workflow keeps timing out due to the step "Installing NFS client" seemingly stalling for upto 15 minutes on the new box image. Bump the timeout to mitigate. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
fix-error-wrapping-1.13
branch
from
7edc45a
to
0f90c7b
Compare
|
Rebased |
jrajahalme
removed
the
dont-merge/needs-rebase
|
/test-backport-1.13 Job 'Cilium-PR-K8s-1.21-kernel-4.19' hit: #30802 (91.90% similarity) |
|
/test-1.21-4.19 |
ti-mo
approved these changes
Apr 23, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Added commit updating golangci-lint version used by
make lintto match that of the GH Go lint action.Once this PR is merged, a GitHub action will update the labels of these PRs: