clustermesh: add hostname endpointslice sync #31814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrFreezeex
requested review from
ysksuzuki,
joamaki,
YutaroHayakawa and
lambdanis
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
MrFreezeex
force-pushed
the
sync-hostname
branch
3 times, most recently
from
4742dca
to
c6ab182
Compare
|
/test |
MrFreezeex
force-pushed
the
sync-hostname
branch
from
c6ab182
to
c862d23
Compare
|
/test |
MrFreezeex
commented
Apr 7, 2024
Sure! So this is linked to the new EndpointSlice sync mechanism that was recently merged (https://github.com/cilium/cilium/pull/28440). And this PR aim to resolve one of the limitation of endpointslice sync about not being able to sync the "hostname" field in an EndpointSlice. For instance, the hostname field is used by StatefulSets to resolve with DNS using ${podName}.${svcName} (instead of just ${svcName}). Hope this helps! |
lambdanis
approved these changes
Apr 9, 2024
lambdanis
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
lambdanis
added
the
area/clustermesh
MrFreezeex
force-pushed
the
sync-hostname
branch
from
c862d23
to
f30c26c
Compare
lambdanis
approved these changes
Apr 9, 2024
MrFreezeex
force-pushed
the
sync-hostname
branch
2 times, most recently
from
9ba92be
to
095f4b2
Compare
|
/test |
joamaki
approved these changes
Apr 12, 2024
ysksuzuki
approved these changes
Apr 16, 2024
MrFreezeex
force-pushed
the
sync-hostname
branch
2 times, most recently
from
15d63d9
to
ab6290b
Compare
joamaki
approved these changes
Apr 24, 2024
|
/test |
MrFreezeex
force-pushed
the
sync-hostname
branch
2 times, most recently
from
29b113f
to
f22b241
Compare
|
(I rebased and run |
|
/test |
This adds hostname synchronization in EndpointSlice. This commit adds the Hostname field in the slims kubernetes struct and propagate that up to the clustermesh's ClusterService struct. Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
MrFreezeex
force-pushed
the
sync-hostname
branch
from
f22b241
to
eea4c1e
Compare
|
/test |
|
/ci-ingress |
|
/ci-l4lb |
|
/ci-ipsec-upgrade |
|
/ci-ingress |
1 similar comment
|
/ci-ingress |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
This adds hostname synchronization in EndpointSlice. This PR adds the Hostname field in the slims kubernetes struct and propagate that up to the clustermesh's ClusterService struct.