bpf: host: restore HostFW for overlay traffic in to-netdev #31818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianwiedmann
added
kind/bug
|
Note that I'm not 100% sure whether we want this behaviour - there's an argument to be made that the HostFW should disregard pod-originating traffic, even if the traffic is encapsulated. We have that opportunity now. But if we want to make that change, let's do it intentionally and not just slip it in. |
|
/test |
Prior to 2860ded ("datapath: mark to-overlay traffic"), overlay traffic would reach the HostFW egress path in to-netdev with MARK_MAGIC_HOST set. Restore this behaviour by also assigning HOST_ID for traffic that has MARK_MAGIC_OVERLAY set. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
As we now have a mark-derived src_sec_identity available, we might as well share this bit of information with the user. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.16-bpf-overlay-hostfw
branch
from
ac99092
to
1ce886d
Compare
|
/test |
This was referenced Apr 9, 2024
julianwiedmann
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.4
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.4
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.10
github-actions
bot
added
backport-done/1.15
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31082 missed one detail in how the HostFW was relying on the packet mark. Restore the old behaviour.