bpf: nat: tolerate non-CT L4 protocols when checking for reply traffic #31820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the blamed commit we ignored any errors from the L4 port extraction, and so traffic that's not supported by CT (eg ESP) would be allowed through. Restore this behaviour by explicitly checking for DROP_CT_UNKNOWN_PROTO. Fixes: 76217a1 ("bpf: nat: Handle errors from snat_v(4|6)_prepare_state()") Reported-by: Paul Chaignon <paul.chaignon@gmail.com> Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
/test |
julianwiedmann
added
kind/bug
julianwiedmann
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
julianwiedmann
added
feature/conntrack
feature/snat
|
(yes, I'll need to polish the release note before merging) |
pchaigno
approved these changes
Apr 8, 2024
3 tasks
maintainer-s-little-helper
bot
added
the
ready-to-merge
13 tasks
nbusseneau
added
backport-pending/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.4
github-actions
bot
added
backport-done/1.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the blamed commit we ignored any errors from the L4 port extraction, and so traffic that's not supported by CT (eg ESP) would be allowed through. Restore this behaviour by explicitly checking for DROP_CT_UNKNOWN_PROTO.
Fixes: 76217a1 ("bpf: nat: Handle errors from snat_v(4|6)_prepare_state()")
Reported-by: Paul Chaignon paul.chaignon@gmail.com