Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contexthelpers: remove unused package #31834

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Apr 8, 2024

The package only defines a single function NewConditionalTimeoutContext which is unused since commit c6eb358 ("etcd: switch lock session to lease manager"). Remove it.

The package only defines a single function NewConditionalTimeoutContext
which is unused since commit c6eb358 ("etcd: switch lock session to
lease manager"). Remove it.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Apr 8, 2024
@tklauser tklauser requested review from a team as code owners April 8, 2024 12:39
@tklauser
Copy link
Member Author

tklauser commented Apr 8, 2024

/test

@tklauser tklauser enabled auto-merge April 8, 2024 12:46
Copy link
Contributor

@marseel marseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tklauser tklauser changed the title contexthelper: remove unused package contexthelpers: remove unused package Apr 9, 2024
@tklauser tklauser added this pull request to the merge queue Apr 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 10, 2024
Merged via the queue into main with commit 50943db Apr 10, 2024
250 checks passed
@tklauser tklauser deleted the pr/tklauser/rm-contexthelper branch April 10, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants