Fix ipset reconciler unit tests #31836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pippolo84
added
kind/bug/CI
|
@aspsk gentle ping for the review 🙏 |
aspsk
approved these changes
Apr 16, 2024
This comment was marked as outdated.
This comment was marked as outdated.
The tests incorrectly register the ipset reconciler twice: first forcefully with reconciler.Register and then at hive build time requesting the reconciler as a parameter in newIPSetManager signature. The two reconcilers are appended to the hive lifecycle and compete to update the simulated ipsets, possibly leading to flakyness. The commit removes the useless initial cell.Invoke. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
force-pushed
the
pr/pippolo84/fix-ipset-tests
branch
from
0cc8fc8
to
704b1bb
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests incorrectly register the ipset reconciler twice: first forcefully with reconciler.Register and then at hive build time requesting the reconciler as a parameter in newIPSetManager signature.
The two reconcilers are appended to the hive lifecycle and compete to update the simulated ipsets, possibly leading to flakyness.
The commit removes the useless initial cell.Invoke.
Related: #31789