loader: rewrite tests to remove gocheck dependency #31841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
added
sig/loader
|
/test |
tklauser
approved these changes
Apr 9, 2024
rgo3
reviewed
Apr 9, 2024
maintainer-s-little-helper
bot
added
ready-to-merge
lmb
force-pushed
the
pr/lmb/loader-remove-checkmate
branch
from
cae9b75
to
885ae67
Compare
|
/test |
rgo3
approved these changes
Apr 10, 2024
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
lmb
force-pushed
the
pr/lmb/loader-remove-checkmate
branch
from
885ae67
to
e55fcfe
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the gocheck dependency from loader test so that I can run them like a sane person. I had to add creating the
cilium_netdevice in tests to make this pass on my laptop.loader: convert TestWrap
loader: convert TestHashDatapath
loader: rewrite cache tests
loader: rewrite tests