Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.13] fqdn: Fix Restore Check Logic #31872

Merged

Conversation

nathanjsweet
Copy link
Member

[ upstream commit 79029db ]

Sometimes restored IPRules do not have the
default "nil" populating their IP maps, but instead have an empty map structure. We need to check for this
restore possibility.

fqdn: Fix minor restore bug that causes false negative checks against a restored DNS IP map.

[ upstream commit 79029db ]

Sometimes restored IPRules do not have the
default "nil" populating their IP maps, but instead have
an empty map structure. We need to check for this
restore possibility.

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@nathanjsweet nathanjsweet added kind/backports This PR provides functionality previously merged into master. release-blocker/1.13 This issue will prevent the release of the next version of Cilium. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels Apr 9, 2024
@nathanjsweet nathanjsweet requested a review from a team as a code owner April 9, 2024 19:33
@nathanjsweet nathanjsweet changed the title fqdn: Fix Restore Check Logic [v1.13] fqdn: Fix Restore Check Logic Apr 9, 2024
@nathanjsweet
Copy link
Member Author

/test-backport-1.13

@nathanjsweet nathanjsweet removed the release-blocker/1.13 This issue will prevent the release of the next version of Cilium. label Apr 9, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 10, 2024
@lmb lmb merged commit e274a96 into v1.13 Apr 10, 2024
148 of 166 checks passed
@lmb lmb deleted the pr/nathanjsweet/backport-fix-fqdn-proxy-restore-check-to-1-13 branch April 10, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants