Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WireGuard: remove cleanup for obsolete IP rules #31874

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

julianwiedmann
Copy link
Member

Once users reach v1.16, they will have upgraded through a Cilium version that no longer uses the IP rules and applies the cleanup logic. So v1.16 doesn't need to bother with the cleanup, and we can remove the relevant code.

Once users reach v1.16, they will have upgraded through a Cilium version
that no longer uses the IP rules and applies the cleanup logic. So v1.16
doesn't need to bother with the cleanup, and we can remove the relevant
code.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added kind/cleanup This includes no functional changes. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/misc This PR makes changes that have no direct user impact. feature/wireguard Relates to Cilium's Wireguard feature labels Apr 10, 2024
@julianwiedmann julianwiedmann requested review from a team as code owners April 10, 2024 08:06
@julianwiedmann julianwiedmann requested a review from brb April 10, 2024 08:06
@julianwiedmann
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 11, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Apr 11, 2024
Merged via the queue into cilium:main with commit 3b04a76 Apr 11, 2024
63 checks passed
@julianwiedmann julianwiedmann deleted the 1.16-wireguard-iprules branch April 11, 2024 16:04
@joestringer joestringer changed the title wireguard: remove cleanup for obsolete IP rules WireGuard: remove cleanup for obsolete IP rules May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. feature/wireguard Relates to Cilium's Wireguard feature kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants