datapath/iptables: remove unused customChain.feederArgs #31876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The customChain.feederArgs field is always populated with a 1-element []string containing the empty string. It was never set to something else since the code was introduced in commit 5bd8c17 ("agent: Masquerade when tunneling is disabled"). Consider it unused and remove it. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
kind/cleanup
|
/test |
|
@gentoo-root could you please take a look? |
aspsk
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The customChain.feederArgs field is always populated with a 1-element []string containing the empty string. It was never set to something else since the code was introduced in commit 5bd8c17 ("agent: Masquerade when tunneling is disabled"). Consider it unused and remove it.