Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multicast: check support for batch lookup #31892

Merged

Conversation

harsimran-pabla
Copy link
Contributor

@harsimran-pabla harsimran-pabla commented Apr 10, 2024

In multicast GroupV4 map, we need to check if kernel supports batch lookup for the map type HashOfMaps.

If batch lookup is not supported, list operation will fallback to iterator lookup.

@harsimran-pabla harsimran-pabla added release-note/misc This PR makes changes that have no direct user impact. area/multicast labels Apr 10, 2024
@harsimran-pabla harsimran-pabla requested a review from a team as a code owner April 10, 2024 18:59
@harsimran-pabla harsimran-pabla force-pushed the hpabla/mcast/check_batchlookup_support branch from 9c920e5 to d6fee88 Compare April 10, 2024 19:02
@harsimran-pabla
Copy link
Contributor Author

/test

pkg/maps/multicast/subscribermap.go Outdated Show resolved Hide resolved
@harsimran-pabla harsimran-pabla force-pushed the hpabla/mcast/check_batchlookup_support branch 2 times, most recently from 4285d2e to 6e3a38a Compare April 17, 2024 13:56
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, may want to move the BatchLookup probe function somewhere useful for other maps.

@harsimran-pabla harsimran-pabla force-pushed the hpabla/mcast/check_batchlookup_support branch from 6e3a38a to 05c95df Compare April 17, 2024 14:41
@harsimran-pabla harsimran-pabla requested a review from a team as a code owner April 17, 2024 14:41
@harsimran-pabla harsimran-pabla force-pushed the hpabla/mcast/check_batchlookup_support branch from 05c95df to 04e03c3 Compare April 17, 2024 14:43
pkg/datapath/linux/probes/probes.go Outdated Show resolved Hide resolved
@harsimran-pabla harsimran-pabla force-pushed the hpabla/mcast/check_batchlookup_support branch 2 times, most recently from d4f2eb4 to af9ecda Compare April 19, 2024 13:14
@harsimran-pabla
Copy link
Contributor Author

/test

Copy link
Contributor

@rgo3 rgo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit/question with regards to exporting the cached feature probe result, otherwise LGTM!

In GroupV4OuterMap which is map of HashOfMaps, we need to check if kernel
supports batch lookup. If batch lookup is not supported, list operation
will fallback to iterator lookup.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla force-pushed the hpabla/mcast/check_batchlookup_support branch from af9ecda to d95a961 Compare April 22, 2024 16:42
@harsimran-pabla
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 22, 2024
@tklauser tklauser enabled auto-merge April 23, 2024 11:13
@tklauser tklauser added this pull request to the merge queue Apr 23, 2024
Merged via the queue into cilium:main with commit dad506e Apr 23, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/multicast ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants