Move cilium/hubble code to cilium/cilium repo #31893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
michi-covalent
force-pushed
the
pr/michi/yes-hubble
branch
from
a131712
to
6eed257
Compare
|
/test |
michi-covalent
force-pushed
the
pr/michi/yes-hubble
branch
4 times, most recently
from
69f511d
to
7676ddb
Compare
|
/test |
michi-covalent
force-pushed
the
pr/michi/yes-hubble
branch
2 times, most recently
from
821bead
to
b91e823
Compare
|
/test |
kaworu
requested changes
Apr 16, 2024
gandro
reviewed
Apr 16, 2024
brlbil
requested changes
Apr 16, 2024
michi-covalent
force-pushed
the
pr/michi/yes-hubble
branch
from
b91e823
to
3a46baa
Compare
glibsm
reviewed
Apr 19, 2024
|
so long years and years of git blame 😢 |
brlbil
approved these changes
Apr 22, 2024
kaworu
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Thanks @michi-covalent, maybe we should consider adding a /hubble/README.md file to clarify that the directory contains the Hubble CLI code (i.e. not the Hubble server part) to make it easier to discover for new contributors.
maintainer-s-little-helper
bot
added
the
ready-to-merge
chancez
approved these changes
Apr 22, 2024
- Copy hubble CLI code at cilium/hubble@10258183. - Include locally-built Hubble CLI in cilium-agent container image. - Add a GitHub workflow to build Hubble CLI release binaries and run integration tests. See CFP-033 [^1] for details. [^1]: cilium/design-cfps#33 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
ti-mo
force-pushed
the
pr/michi/yes-hubble
branch
from
81b0cfd
to
d849e1d
Compare
|
/test |
maintainer-s-little-helper
bot
removed
the
ready-to-merge
ti-mo
approved these changes
Apr 23, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
May 5, 2024
Hubble CLI code recently got moved into cilium/cilium repo [^1]. Import github.com/cilium/cilium/hubble instead of github.com/cilium/hubble to remove cilium/hubble dependency. [^1]: cilium/cilium#31893 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
May 7, 2024
Hubble CLI code recently got moved into cilium/cilium repo [^1]. Import github.com/cilium/cilium/hubble instead of github.com/cilium/hubble to remove cilium/hubble dependency. [^1]: cilium/cilium#31893 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integration tests.
See CFP-033 1 for details.
For reviewers:
Please review the following files carefully:
.github/workflows/hubble-cli.yamlCODEOWNERSgo.modhubble/Makefileimages/cilium/DockerfileThe following files don't have any logic changes except for fixing import paths and lint errors:
hubble/cmd/*hubble/main.gohubble/pkg/*Footnotes
https://github.com/cilium/design-cfps/pull/33 ↩