Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.14-backport] Introduce fromEgressProxyRule #31926

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

jschwinger233
Copy link
Member

@jschwinger233 jschwinger233 commented Apr 12, 2024

@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Apr 12, 2024
@jschwinger233 jschwinger233 force-pushed the gray/1.14/proxy-route-fix branch 2 times, most recently from c2f21d5 to 28e8acb Compare April 26, 2024 03:55
[ upstream commit: 7d278af ]

[ backporter's note: v1.14 uses bpf/init.sh to install proxy rules so we
have to do a customized backport. ]

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
[ upstream commit: 53133ff ]

[ backporter's note: v1.14 uses bpf/init.sh to install proxy rules so we
have to do a customized backport. ]

Although we don't install fromEgressProxyRule for now, this commit
insists on removing it to make sure further downgrade can go smoothly.

Soon We'll have another PR to install fromEgressProxyRule, and cilium
downgrade from that PR to branch tip (patch downgrade, 1.X.Y ->
1.X.{Y-1}) will be broken if we don't handle the new ip rule carefullly.

Without this patch, downgrade from higher version will leave
fromEgressProxyRule on the lower version cilium, cluster will be in a
wrong status of "having stale ip rule + not having other necessary
settings (iptables)", breaking the connectivity.

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
@jschwinger233 jschwinger233 changed the title [v1.14] Introduce fromEgressProxyRule [v1.14-backport] Introduce fromEgressProxyRule Apr 26, 2024
@jschwinger233
Copy link
Member Author

/test-backport-1.14

@jschwinger233 jschwinger233 marked this pull request as ready for review April 26, 2024 05:34
@jschwinger233 jschwinger233 requested a review from a team as a code owner April 26, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

None yet

2 participants