Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Correct name of "cert-manager" in tab groups #31929

Merged
merged 1 commit into from
Apr 12, 2024
Merged

docs: Correct name of "cert-manager" in tab groups #31929

merged 1 commit into from
Apr 12, 2024

Conversation

JamesLaverack
Copy link
Member

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

cert-manager exclusively uses the lowercase hyphenated form of its name, even as the first word in a sentence. No release note needed as this is a docs-only change.

@JamesLaverack
Correct name of "cert-manager" in tab groups
8b678e8 
cert-manager exclusively uses the lowercase hyphenated form of its
name, even as the first word in a sentence.

Signed-off-by: James Laverack <james@isovalent.com>
@JamesLaverack JamesLaverack requested review from a team as code owners April 12, 2024 09:54
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 12, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Apr 12, 2024
@sayboras sayboras changed the title Correct name of "cert-manager" in tab groups docs: Correct name of "cert-manager" in tab groups Apr 12, 2024
@sayboras sayboras added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Apr 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 12, 2024
sayboras
sayboras approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ha, I didn't know that ✔️

@sayboras
Copy link
Member

/test

qmonnet
qmonnet approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 12, 2024
@qmonnet qmonnet added this pull request to the merge queue Apr 12, 2024
Merged via the queue into cilium:main with commit 076cc7e Apr 12, 2024
60 checks passed
@JamesLaverack JamesLaverack mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JamesLaverack @sayboras @qmonnet