Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l2announcer: Use the device table to access devices #31931

Merged

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented Apr 12, 2024

Remove references to l2announcer from daemon/cmd and add the watching of the device table into l2 announcer.

@joamaki joamaki added the release-note/misc This PR makes changes that have no direct user impact. label Apr 12, 2024
Copy link
Member

@dylandreimerink dylandreimerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joamaki joamaki marked this pull request as ready for review April 15, 2024 08:44
@joamaki joamaki requested a review from a team as a code owner April 15, 2024 08:44
@joamaki joamaki requested a review from ldelossa April 15, 2024 08:44
Remove references to l2announcer from daemon/cmd and
add the watching of the device table into l2 announcer.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki force-pushed the pr/jomaaki/l2-announcement-use-devices-table branch from a0518b5 to 2c6fc7b Compare April 16, 2024 12:52
@joamaki
Copy link
Contributor Author

joamaki commented Apr 16, 2024

/test

@joamaki joamaki enabled auto-merge April 16, 2024 12:53
@joamaki
Copy link
Contributor Author

joamaki commented Apr 24, 2024

/test

@joamaki
Copy link
Contributor Author

joamaki commented Apr 24, 2024

ping @ldelossa

auto-merge was automatically disabled April 24, 2024 12:36

Pull Request is not mergeable

@tklauser tklauser added this pull request to the merge queue Apr 25, 2024
Merged via the queue into cilium:main with commit 9e9394d Apr 25, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants