Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Remove deprecated option containerRuntime.integration #31942

Merged
merged 1 commit into from
Apr 16, 2024
Merged

helm: Remove deprecated option containerRuntime.integration #31942

merged 1 commit into from
Apr 16, 2024

Conversation

sayboras
Copy link
Member

Relates: #24161

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 13, 2024
@sayboras sayboras added kind/cleanup This includes no functional changes. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/helm Impacts helm charts and user deployment experience labels Apr 13, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 13, 2024
@sayboras sayboras force-pushed the pr/tammach/remove-deprecated-values branch from ebfb8ee to dafdba4 Compare April 13, 2024 05:19
@sayboras
helm: Remove deprecated option containerRuntime.integration
303a619 
Relates: #24161
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/remove-deprecated-values branch from dafdba4 to 303a619 Compare April 13, 2024 05:23
@sayboras sayboras marked this pull request as ready for review April 13, 2024 06:52
@sayboras sayboras requested review from a team as code owners April 13, 2024 06:52
@sayboras
Copy link
Member Author

/test

learnitall
learnitall approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Thank you!

@sayboras sayboras added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit e8b940f Apr 16, 2024
263 checks passed
@sayboras sayboras deleted the pr/tammach/remove-deprecated-values branch April 16, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@learnitall learnitall learnitall approved these changes

@joamaki joamaki Awaiting requested review from joamaki joamaki is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience kind/cleanup This includes no functional changes. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sayboras @gandro @learnitall