Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpv2: introducing service reconciler in BGPv2 reconcilers #31962

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

harsimran-pabla
Copy link
Contributor

Adding service reconcilers in BGPv2 implementation. This change also includes unit tests.

BGPv2 service reconcilers will support services of type LB, cluster IP and external IP for BGP advertisement. As well as external and internal traffic policy constructs.

This is continuation of BGPv2 implementation.

Adding PeerAdvertisementsEqual method and corresponding unit tests, this
is equivalent of DeepEqual method. Auto-generation of this is not
possible as slice as map is not supported by auto-gen deep equal
method generator.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla added the release-note/misc This PR makes changes that have no direct user impact. label Apr 15, 2024
@harsimran-pabla harsimran-pabla requested a review from a team as a code owner April 15, 2024 14:15
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, the logic LGTM, but found something that looks like an IDE rename issue.

pkg/bgpv1/manager/reconcilerv2/service.go Outdated Show resolved Hide resolved
pkg/bgpv1/manager/reconcilerv2/service.go Outdated Show resolved Hide resolved
Adding service reconcilers in BGPv2 implementation. This change also
includes unit tests.

BGPv2 service reconcilers will support services of type LB, cluster IP
and external IP for BGP advertisement. As well as external and internal
traffic policy constructs.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@harsimran-pabla
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 16, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Apr 16, 2024
Merged via the queue into cilium:main with commit e3ea2ed Apr 16, 2024
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bgp ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants