Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: improve Flatcar section #31986

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Docs: improve Flatcar section #31986

merged 1 commit into from
Apr 17, 2024

Conversation

darox
Copy link
Contributor

@darox darox commented Apr 16, 2024

This commit makes it more clear, that
Flatcar only faces issues on AWS EKS ENI
mode.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc

This commit makes it more clear, that Flatcar only faces issues on AWS EKS ENI mode.

@darox darox requested review from a team as code owners April 16, 2024 09:47
@darox darox requested review from aspsk and lambdanis April 16, 2024 09:47
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 16, 2024
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Apr 16, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 16, 2024
gandro
gandro approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@darox darox requested a review from qmonnet April 16, 2024 15:14
qmonnet

This comment was marked as resolved.

Sign in to view

@darox
Docs: improve Flatcar section
38ebd3c 
This commit makes it more clear, that
Flatcar only faces issues on AWS EKS ENI
mode.

Signed-off-by: darox <maderdario@gmail.com>
@darox
Copy link
Contributor Author

darox commented Apr 16, 2024

Sorry for the confusion, I didn't mean to accept my suggestion “as-is”: I copied the block that was coming below, because I couldn't create a suggestion on that block in the GitHub interface. But the block is not duplicated:

image

Please fix (and wrap the last line of the paragraph).

I'm sorry for the mess I did. Should be fine now.

@darox darox requested a review from qmonnet April 16, 2024 15:45
@qmonnet
Copy link
Member

qmonnet commented Apr 16, 2024

Thanks!

@joestringer
Copy link
Member

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 17, 2024
@lmb lmb added this pull request to the merge queue Apr 17, 2024
Merged via the queue into cilium:main with commit ae28b61 Apr 17, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@lambdanis lambdanis lambdanis approved these changes

@aspsk aspsk aspsk approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@darox @qmonnet @joestringer @gandro @lambdanis @aspsk @lmb