-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clean up example yaml for L4 Deny Policy #32015
Conversation
Commit 9359b55 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
9359b55
to
1627b0e
Compare
@huntergregory Thanks for the PR! Have the ports in the example been double checked? If so, the change looks good to me. Could you just amend the commit message to have the same subject as the PR title? It looks more descriptive. |
Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
1627b0e
to
b48038f
Compare
Updated! Thanks @lambdanis . Ports were the same, but just now thinking to switch the order align more with the blurb?
|
/test |
Fixes an example L4 Deny Policy in the documentation, removing a developer's note in the yaml referenced by https://github.com/cilium/cilium/blob/main/Documentation/security/policy/language.rst
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.