Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clean up example yaml for L4 Deny Policy #32015

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

huntergregory
Copy link
Contributor

@huntergregory huntergregory commented Apr 17, 2024

Fixes an example L4 Deny Policy in the documentation, removing a developer's note in the yaml referenced by https://github.com/cilium/cilium/blob/main/Documentation/security/policy/language.rst

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

@huntergregory huntergregory requested a review from a team as a code owner April 17, 2024 01:13
@maintainer-s-little-helper
Copy link

Commit 9359b55 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 17, 2024
@huntergregory huntergregory changed the title docs: fix bug in example yaml docs: clean up example yaml for L4 Deny Policy Apr 17, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Apr 17, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Apr 17, 2024
@lambdanis lambdanis added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. and removed area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Apr 17, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 17, 2024
@lambdanis lambdanis added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 17, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 17, 2024
@lambdanis
Copy link
Contributor

@huntergregory Thanks for the PR!

Have the ports in the example been double checked? If so, the change looks good to me.

Could you just amend the commit message to have the same subject as the PR title? It looks more descriptive.

Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
@huntergregory
Copy link
Contributor Author

@huntergregory Thanks for the PR!

Have the ports in the example been double checked? If so, the change looks good to me.

Could you just amend the commit message to have the same subject as the PR title? It looks more descriptive.

Updated! Thanks @lambdanis . Ports were the same, but just now thinking to switch the order align more with the blurb?

The following policy will allow ingress traffic for any node with the label
type=ingress-worker on TCP ports 22, 6443 (kube-apiserver), 2379 (etcd) and 4240
(health checks), as well as UDP port 8472 (VXLAN).

@lambdanis
Copy link
Contributor

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 25, 2024
@ti-mo ti-mo added this pull request to the merge queue Apr 25, 2024
Merged via the queue into cilium:main with commit 7df88fe Apr 25, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants