-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid PromQL query in the Cilium Metrics Grafana dashboard #32017
Fix invalid PromQL query in the Cilium Metrics Grafana dashboard #32017
Conversation
Commit ab0dca3 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
ab0dca3
to
fa939ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please remove the merge commit.
fa939ae
to
ab4eb0b
Compare
Should be good now |
ab4eb0b
to
36292ab
Compare
/test |
/test |
Signed-off-by: Michael Mykhaylov <32168861+mikemykhaylov@users.noreply.github.com>
36292ab
to
6bb2da9
Compare
/test |
Added backport labels, sounds like this is essentially a docs bug. |
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
The existing query for the Policies per Node chart in the Cilium Metrics dashboard in the
monitoring-example.yaml
contained invalid PromQL. Additionally, the correct value to be filtered on is "failure", not "fail".