hive: Rebase on cilium/hive

[bimmlerd]

The general idea is to have pkg/hive contain the cilium-specific adaptations of cilium/hive. Specifically, that's providing certain cells like statedb and jobs directly, and having module decorators creating the right health and logging components.

It's one big commit as it has proven difficult to get intermediate commits to compile (which our CI mandates). The health part needs a bit of love after this, we can probably move healthv2 into hive/health as it's strongly tied to cilium's hive.

The bulk of the changes are mechanical. The categories are:

1. import path change from cilium/cilium/pkg/hive/{cell,job} to cilium/hive/{cell,job}
2. giving hive.{Start,Stop,Run} an slog.Logger to provide to the hive,
3. changes to the health interfaces - Scope and HealthReporter are unified under just Health
4. modules are provided with a job group scoped to their module id directly, instead of having to create a group from a registry

[bimmlerd]

/test

[bimmlerd]

/test

[bimmlerd]

/test

[gandro]

Thanks so much for cleaning up the imports! I did find some instances in my CODEOWNERs where the imports cleanup went slightly wrong (I have not checked files not owned by me)

[gandro]

Awesome, this looks good to me now 🚀

[bimmlerd]

/test

[chancez]

Hubble related changes lgtm.

[learnitall]

Woohoo! 🥳. Quick clarifying question for you, but otherwise LGTM for API changes.

[learnitall]

I did a quick sanity check and I think there are still some places where the old hive package is referenced. Were these left in on purpose? It looks like there are some leftover references in Documentation and comments, as well as some leftover imports to github.com/cilium/cilium/pkg/hive:

$ grep 'pkg/hive' -R . --include \*.go --include \*.rst | wc -l
89

Examples:

./Documentation/contributing/development/hive.rst:`hive.New <https://pkg.go.dev/github.com/cilium/cilium/pkg/hive#New>`_ constructor. 
./vendor/github.com/cilium/hive/hive.go:// See pkg/hive/example for a runnable example application.
./pkg/proxy/logger/logger_test.go:	"github.com/cilium/cilium/pkg/hive"

[bimmlerd]

I did a quick sanity check and I think there are still some places where the old hive package is referenced. Were these left in on purpose? It looks like there are some leftover references in Documentation and comments, as well as some leftover imports to github.com/cilium/cilium/pkg/hive:

$ grep 'pkg/hive' -R . --include \*.go --include \*.rst | wc -l
89

Examples:

./Documentation/contributing/development/hive.rst:`hive.New <https://pkg.go.dev/github.com/cilium/cilium/pkg/hive#New>`_ constructor. 
./vendor/github.com/cilium/hive/hive.go:// See pkg/hive/example for a runnable example application.
./pkg/proxy/logger/logger_test.go:	"github.com/cilium/cilium/pkg/hive"

These are intentional. The PR's purpose is not to remove pkg/hive, but to use the implementation of hive in github.com/cilium/hive. cilium/hive is meant to be usable for projects unrelated to cilium, whereas github.com/cilium/cilium/pkg/hive is the adaptation of hive for the purposes of the cilium agent (see PR description/commit message). pkg/hive/job and pkg/hive/cell are removed from cilium/cilium, hence these import paths had to be rewritten, but not pkg/hive, as, for example, pkg/hive.New is how we inject our default cells into the hive.

[bimmlerd]

/test

[learnitall]

Looks good, thank you! My apologies for the oversite there 🤦

[bimmlerd]

/test