-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix prometheus port regex #32030
Conversation
Commit 8e7a979 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Signed-off-by: James Bodkin <james.bodkin@amphora.net>
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @JBodkin-Amphora.
It looks like the original examples come from some ancient version of Prometheus like v0.19.0. On a side note, Cilium docs around Prometheus could use a general refresh IMO, hopefully one day :)
The example documentation in prometheus has a different regex pattern compared cilium. In some instances, prometheus or the opentelemetry collector is not picking up the correct port, because the relabel config is not applying since the regex doesn't match.