-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hive: Reduce hive trace logs to debug level #32033
Conversation
/test |
The cilium-agent logs get spammed with this information in standard environments, but these logs are not generally useful for users to understand what's going on. The vast majority of them take microseconds to run so they don't have any meaningful impact on startup. Create a threshold to only report long-running tasks at info level, while leaving most such reporting at debug level. Signed-off-by: Joe Stringer <joe@cilium.io>
5d482db
to
7ca124e
Compare
/test |
CI hit #32038, not a required workflow. |
Probably it makes sense to align behind the proper implementation for the library and just update this to match, so we can be sure both trees are in sync? I'll iterate in cilium/hive#2 for now. |
I didn't realize how far |
The cilium-agent logs get spammed with this information in standard
environments, but these logs are not generally useful for users to
understand what's going on. The vast majority of them take microseconds
to run so they don't have any meaningful impact on startup.
Create a threshold to only report long-running tasks at info level,
while leaving most such reporting at debug level.
See also corresponding Hive library PR cilium/hive#2.