Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hostPort dependency on BPF NodePort #32046

Merged
merged 1 commit into from Apr 24, 2024
Merged

Remove hostPort dependency on BPF NodePort #32046

merged 1 commit into from Apr 24, 2024

Conversation

chaunceyjiang
Copy link
Member

Remove hostPort dependency on BPF NodePort

Fixes: #31532

Remove hostPort dependency on BPF NodePort

@chaunceyjiang
Remove hostPort dependency on BPF NodePort
edc6c5b 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 18, 2024
@chaunceyjiang
Copy link
Member Author

/test

@chaunceyjiang chaunceyjiang marked this pull request as ready for review April 23, 2024 06:12
@chaunceyjiang chaunceyjiang requested a review from a team as a code owner April 23, 2024 06:12
@chaunceyjiang
Copy link
Member Author

@markpash Can you please add this PR to the merge queue?

@markpash
Copy link
Contributor

@markpash Can you please add this PR to the merge queue?

I'm not sure that's something I need to do. Currently the helper bot is complaining about the PR not having the correct release note label. Perhaps if that's fixed it will get the green-light.

@borkmann
Copy link
Member

@chaunceyjiang Please add a proper commit description which explain the concrete problem you are solving and why this patch is needed.

@squeed squeed added the release-note/misc This PR makes changes that have no direct user impact. label Apr 24, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 24, 2024
@squeed squeed added this pull request to the merge queue Apr 24, 2024
Merged via the queue into cilium:main with commit 94c5468 Apr 24, 2024
63 checks passed
@borkmann
Copy link
Member

@squeed can we pls revert this? It's not even clear what this fixes in the first place.

@chaunceyjiang
Copy link
Member Author

@chaunceyjiang Please add a proper commit description which explain the concrete problem you are solving and why this patch is needed.

My understanding is that disable NodePort will also disable hostPort. From the description, this dependency does not seem to be necessary.

@squeed squeed mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpash markpash markpash approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove hostPort dependency on BPF NodePort
4 participants
@chaunceyjiang @markpash @borkmann @squeed