ci-l4lb: Remove unnecessary untrusted checkout #32071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be running the test code from a trusted branch which was already checked out earlier, then we pass in the sha of the image compiled from CI into the script so it can run the docker image in the test environment. Since the pull request was checked out to another branch that wasn't being used, it should be fine to just drop that step. Signed-off-by: Joe Stringer <joe@cilium.io>
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be running the test code from a trusted branch which was
already checked out earlier, then we pass in the sha of the image
compiled from CI into the script so it can run the docker image in the
test environment. Since the pull request was checked out to another
branch that wasn't being used, it should be fine to just drop that step.