loader: sanitize bpffs directory strings for netdevs #32090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpffs directory paths cannot contain the character ".", thus we must sanitize device names that contain any "." characters. Our solution is to replace "." with "-". This introduces a risk of naming collisions, e.g. "eth.0" and "eth-0", in practice the probability of this happening should be very small. Fixes: cilium#31813 Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
rgo3
added
sig/loader
|
/test |
borkmann
approved these changes
Apr 19, 2024
dylandreimerink
approved these changes
Apr 19, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
This should be backported to v1.15.x... etc. It's currently broken in v1.15.4. I submitted an issue which I think is directly caused by this: #32095 |
9 tasks
jschwinger233
added
backport-pending/1.15
3 tasks
github-actions
bot
added
backport-done/1.15
samip5
added a commit
to samip5/k8s-cluster
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpffs directory paths cannot contain the character ".", thus we must sanitize device names that contain any "." characters. Our solution is to replace "." with "-". This introduces a risk of naming collisions, e.g. "eth.0" and "eth-0", in practice the probability of this happening should be very small.
Fixes: #31813