egressgw: minor bpf refactors #32094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect() Cleanly split up the EgressGW policy lookup, and the subsequent ipcache lookup. No functional change. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
sig/datapath
|
/test |
Introduce a slightly better separation between 1. interpreting the CT result, 2. performing the actual EGW policy lookup & evaluation, 3. determining whether the selected gateway is local or remote. Also allow the policy lookup to return a DROP_* reason, without intermediate transport via the tunnel_endpoint variable. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
EGW is incompatible with IPsec, and so __encap_and_redirect_lxc() will never return CTX_ACT_OK. We currently also *can't* pass the packet to the stack for encryption, as there's no code in bpf_host that would catch it and handle the EGW redirect to the gateway node. Therefore remove the unused & confusing code. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.16-bpf-egressgw-refactor
branch
from
4eebde0
to
336322a
Compare
|
/test |
julianwiedmann
added
the
dont-merge/preview-only
julianwiedmann
removed
the
dont-merge/preview-only
ysksuzuki
approved these changes
Apr 24, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly refactors some of the EGW bpf code, so that we have low-level EGW helpers that are only concerned about the map lookup & interpreting the result. High-level logic (ie. EGW only handles outbound connections) gets applied independently of what the policy mechanism looks like, and error propagation is more straight-forward.