-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add EnableDefaultDeny documentation #32097
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
added
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
area/misc
Impacts miscellaneous areas of the code not otherwise owned by another area.
labels
Apr 19, 2024
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
labels
Apr 19, 2024
squeed
added
release-note/misc
This PR makes changes that have no direct user impact.
and removed
area/misc
Impacts miscellaneous areas of the code not otherwise owned by another area.
labels
Apr 19, 2024
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Apr 19, 2024
qmonnet
requested changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've got a few nits, nothing major.
This adds more complication to the logic for determining an endpoint's default policy mode, so pull that in to its own section. Then, add the docs for EnableDefaultDeny. While we're at it, clean up obsolete configuration references; we don't support configuration by environment variable anyore. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
squeed
force-pushed
the
document-non-default-deny
branch
from
April 22, 2024 13:28
656c42c
to
a2d405e
Compare
qmonnet
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
/test |
christarazi
approved these changes
Apr 22, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more complication to the logic for determining an endpoint's default policy mode, so pull that in to its own section. Then, add the docs for EnableDefaultDeny.
While we're at it, clean up obsolete configuration references; we don't support configuration by environment variable anymore.