Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add EnableDefaultDeny documentation #32097

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Apr 19, 2024

This adds more complication to the logic for determining an endpoint's default policy mode, so pull that in to its own section. Then, add the docs for EnableDefaultDeny.

While we're at it, clean up obsolete configuration references; we don't support configuration by environment variable anymore.

@squeed squeed added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Apr 19, 2024
@squeed squeed requested review from a team as code owners April 19, 2024 20:26
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 19, 2024
@squeed squeed added release-note/misc This PR makes changes that have no direct user impact. and removed area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Apr 19, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 19, 2024
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've got a few nits, nothing major.

Documentation/security/policy/intro.rst Outdated Show resolved Hide resolved
Documentation/security/policy/intro.rst Outdated Show resolved Hide resolved
Documentation/security/policy/intro.rst Outdated Show resolved Hide resolved
Documentation/security/policy/intro.rst Outdated Show resolved Hide resolved
Documentation/security/policy/intro.rst Outdated Show resolved Hide resolved
Documentation/security/policy/intro.rst Outdated Show resolved Hide resolved
This adds more complication to the logic for determining an endpoint's
default policy mode, so pull that in to its own section. Then, add the
docs for EnableDefaultDeny.

While we're at it, clean up obsolete configuration references; we don't
support configuration by environment variable anyore.

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@squeed squeed requested a review from qmonnet April 22, 2024 13:28
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@qmonnet
Copy link
Member

qmonnet commented Apr 22, 2024

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 22, 2024
@squeed squeed added this pull request to the merge queue Apr 22, 2024
Merged via the queue into cilium:main with commit 7f5b1ea Apr 22, 2024
59 checks passed
@squeed squeed deleted the document-non-default-deny branch April 22, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants