Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: Updates for release 1.15.4, 1.14.10, 1.13.15 #32098

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

asauber
Copy link
Member

@asauber asauber commented Apr 19, 2024

Readme: Updates for release 1.15.4, 1.14.10, 1.13.15

Signed-off-by: Andrew Sauber <2046750+asauber@users.noreply.github.com>
@asauber asauber requested review from a team as code owners April 19, 2024 22:21
@asauber asauber requested a review from qmonnet April 19, 2024 22:21
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 19, 2024
@asauber asauber added the release-note/misc This PR makes changes that have no direct user impact. label Apr 19, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 19, 2024
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qmonnet
Copy link
Member

qmonnet commented Apr 22, 2024

/test

Copy link
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like stable.txt isn't in CODEOWNERS, should it be? cc @aanm

@aanm
Copy link
Member

aanm commented Apr 24, 2024

Looks like stable.txt isn't in CODEOWNERS, should it be? cc @aanm

@ti-mo it is in

/stable.txt @cilium/tophat

@ti-mo
Copy link
Contributor

ti-mo commented Apr 24, 2024

Looks like stable.txt isn't in CODEOWNERS, should it be? cc @aanm

@ti-mo it is in

/stable.txt @cilium/tophat

Hmm, why assign things to tophat? Shouldn't it get assigned to people working on releases? TH is a revolving door, their reviews go stale after a week (and already have enough stuff to rubber-stamp).

@aanm aanm merged commit a59aeea into cilium:main Apr 25, 2024
60 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants