cilium-health: Fix setting of disable_ipv6 sysctl #32120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joamaki
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
The disable_ipv6 sysctl setting is changed for the "cilium" veth interface inside the cilium health network namespace. For that we cannot use the normal sysctl API as that operates in the host network namespace. Instead we need to do a direct sysctl. This fixes this sysctl health degradation which happens due to the sysctl setting happening on the wrong network namespace: "Error":"could not open the sysctl file /host/proc/sys/net/ipv6/conf/cilium/disable_ipv6: open /host/proc/sys/net/ipv6/conf/cilium/disable_ipv6: no such file or directory" Fixes: 2079aa4 ("datapath/sysctl: Use generic reconciler for sysctl params") Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
pr/joamaki/fix-health-disable-ipv6
branch
from
38e4822
to
62a4e83
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disable_ipv6 sysctl setting is changed for the "cilium" veth interface inside the cilium health network namespace. For that we cannot use the normal sysctl API as that operates in the host network namespace. Instead we need to do a direct sysctl.
This fixes this sysctl health degradation which happens due to the sysctl setting happening on the wrong network namespace:
"Error":"could not open the sysctl file /host/proc/sys/net/ipv6/conf/cilium/disable_ipv6:
open /host/proc/sys/net/ipv6/conf/cilium/disable_ipv6: no such file or directory"
Fixes: 2079aa4 ("datapath/sysctl: Use generic reconciler for sysctl params")
Marking this as "release-note/misc" without a release note as this fixes an issue in an unreleased version
of Cilium.