helm: no operator hostPorts when hostNetwork is disabled #32127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: fbe159f ("helm: possibility to disable hostNetwork for operator") Signed-off-by: Petr Baloun <petr.baloun@firma.seznam.cz>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
gandro
approved these changes
Apr 22, 2024
gandro
added
release-note/misc
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
|
/test |
joamaki
approved these changes
Apr 22, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: fbe159f ("helm: possibility to disable hostNetwork for operator")
My previous PR implementing configurable host network for operator missed
hostPortparameter inprometheusport definition. Operator worked fine without this but cluster nodes we quickly depleted as, with this setting, just one operator pod per node is allowed. This PR omitshostPortparameter when host network is disabled.