ingress: change hostnetwork default port to unprivileged 8080 #32159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when using Ingress hostnetwork support, the Envoy listener port defaults to the privileged port `80` if no other port is defined via Helm Chart (Shared Ingress) or K8s Annotation (Dedicated Ingress). This results in bind errors because the Envoy process of the Cilium Proxy doesn't have the respective capabilities (`NET_BIND_SERVICE`) to bind to privileged ports. Therefore, this commit changes the default port to `8080` (unprivileged). Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
added
kind/cleanup
|
/test |
sayboras
approved these changes
Apr 24, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
mhofstetter
deleted the
pr/mhofstetter/ingress-hostnetwork-def-port-8080
branch
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using Ingress hostnetwork support, the Envoy listener port defaults to the privileged port
80if no other port is defined via Helm Chart (Shared Ingress) or K8s Annotation (Dedicated Ingress).This results in bind errors because the Envoy process of the Cilium Proxy doesn't have the respective capabilities (
NET_BIND_SERVICE) to bind to privileged ports.Even if it should eventually become possible to enable binds on privileged ports - the default will be that privileged binds aren't allowed. Hence, this commit changes the default port to the unprivileged port
8080.Note: Ingress on HostNetwork is an unreleased feature - hence it should be OK to change the default port.
Relates to: #32158
Relates to: #30840