CODEOWNERS: Remove the catch-all rule #32174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
michi-covalent
force-pushed
the
pr/michi/own-it-man
branch
from
9459cdb
to
3e8ff7b
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
michi-covalent
requested review from
a team,
nebril and
asauber
and removed request for
a team
michi-covalent
force-pushed
the
pr/michi/own-it-man
branch
from
3e8ff7b
to
24b638a
Compare
michi-covalent
force-pushed
the
pr/michi/own-it-man
branch
from
24b638a
to
88269d1
Compare
|
for the following files it might make sense to create a new |
michi-covalent
force-pushed
the
pr/michi/own-it-man
branch
from
88269d1
to
6b536ae
Compare
|
/test |
auto-merge was automatically disabled
April 25, 2024 00:37
Pull Request is not mergeable
auto-merge was automatically disabled
April 25, 2024 00:37
Pull Request is not mergeable
joestringer
reviewed
Apr 25, 2024
michi-covalent
force-pushed
the
pr/michi/own-it-man
branch
from
6b536ae
to
2432b03
Compare
|
/test |
|
Oh, TIL https://github.com/cilium/cilium/blob/main/.github/workflows/lint-codeowners.yaml. Looks like we don't really need another codeowners checker then. Thanks Michi! |
ti-mo
approved these changes
Apr 25, 2024
gandro
reviewed
Apr 25, 2024
tklauser
reviewed
Apr 25, 2024
qmonnet
reviewed
Apr 25, 2024
nebril
approved these changes
Apr 25, 2024
michi-covalent
force-pushed
the
pr/michi/own-it-man
branch
from
2432b03
to
6a8aa39
Compare
michi-covalent
force-pushed
the
pr/michi/own-it-man
branch
from
6a8aa39
to
937e487
Compare
|
/test |
michi-covalent
commented
Apr 25, 2024
asauber
approved these changes
Apr 26, 2024
|
need a quick ack from @cilium/docs-structure team for the auto-generated Documentation/codeowners.rst file 🚀🙏 |
joestringer
approved these changes
Apr 26, 2024
Remove the catch-all rule to avoid pulling in tophat for review whenever new files get added. Pulling in tophat is unnecessary because: - lint-codeowners.yaml [^1] validates CODEOWNERS has entries for new files. - cilium/contributing team owns CODEOWNERS file. This team can ensure that new files get placed in appropriate locations. [^1]: https://github.com/cilium/cilium/blob/main/.github/workflows/lint-codeowners.yaml Suggested-by: Timo Beckers <timo@isovalent.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/own-it-man
branch
from
937e487
to
b71f94a
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the catch-all rule to avoid pulling in tophat for review whenever new files get added. Pulling in tophat is unnecessary because:
Suggested-by: Timo Beckers timo@isovalent.com
Footnotes
https://github.com/cilium/cilium/blob/main/.github/workflows/lint-codeowners.yaml ↩