Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress: move flag ingress-default-xff-num-trusted-hops to cell config #32190

Merged

Conversation

mhofstetter
Copy link
Member

This commit moves the Cilium Operator flag ingress-default-xff-num-trusted-hops from the global Operator Config struct into the config struct of the corresponding Ingress hive cell.

This commit moves the Cilium Operator flag `ingress-default-xff-num-trusted-hops`
from the global Operator Config struct into the config struct of the corresponding
Ingress hive cell.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-ingress labels Apr 25, 2024
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review April 25, 2024 13:30
@mhofstetter mhofstetter requested review from a team as code owners April 25, 2024 13:30
@mhofstetter mhofstetter requested review from nebril, sayboras and jrajahalme and removed request for sayboras April 25, 2024 13:30
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 26, 2024
@sayboras sayboras added this pull request to the merge queue Apr 28, 2024
Merged via the queue into cilium:main with commit 198b794 Apr 28, 2024
65 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/ingress-xff-hops-cellify branch April 29, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-ingress kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants