Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Replace gocheck with built-in go test #32210

Merged
merged 4 commits into from Apr 30, 2024
Merged

cli: Replace gocheck with built-in go test #32210

merged 4 commits into from Apr 30, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Apr 28, 2024 •
edited

Please refer to individual commits for more details, this PR is focusing on files owned by cilium-cli team.

Relates: #28596

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 28, 2024
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Apr 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 28, 2024
@sayboras
bugtool/cmd: Replace gocheck with built-in go test
5bbae22 
The setup and teardown steps are simplified by t.TempDir function.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
cilium-dbg/cmd: Replace gocheck with built-in go test
792fe58 
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
pkg/command: Replace gocheck with built-in go test
0d03c8a 
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
pkg/logging: Replace gocheck with built-in go test
9bb995f 
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras mentioned this pull request Apr 28, 2024
Closed
@sayboras sayboras marked this pull request as ready for review April 28, 2024 12:14
@sayboras sayboras requested review from a team as code owners April 28, 2024 12:14
@sayboras
Copy link
Member Author

/ci-integration

@sayboras
Copy link
Member Author

/test

@sayboras sayboras changed the title cilium-cli: Replace gocheck with built-in go test cli: Replace gocheck with built-in go test Apr 30, 2024
@sayboras sayboras enabled auto-merge April 30, 2024 15:02
asauber
asauber approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@asauber asauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, although I would prefer to see the switch in the test logic (a new assert function is new logic!), broken out into separate commits.

@sayboras sayboras added this pull request to the merge queue Apr 30, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 30, 2024
Merged via the queue into main with commit 6fca78d Apr 30, 2024
266 of 270 checks passed
@sayboras sayboras deleted the pr/tammach/gocheck-cli branch April 30, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@asauber asauber asauber approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sayboras @pchaigno @asauber