loader: implement seamless tcx to legacy tc downgrade #32228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to confusion around the semantics of the tcx API, we believed downgrading tcx to legacy tc attachments couldn't be done seamlessly. This doesn't seem to be the case. As documented in the code, install the legacy tc attachment first, then remove any existing tcx attachment for the program. Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
added
sig/loader
|
/test |
rgo3
approved these changes
Apr 29, 2024
borkmann
approved these changes
Apr 29, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
1 task
borkmann
added
backport-pending/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.5
borkmann
added
backport-done/1.15
maintainer-s-little-helper
bot
moved this from Backport pending to v1.15
to Backport done to v1.15
in 1.15.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to confusion around the semantics of the tcx API, we believed downgrading tcx to legacy tc attachments couldn't be done seamlessly. This doesn't seem to be the case. As documented in the code, install the legacy tc attachment first, then remove any existing tcx attachment for the program.