Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install/kubernetes: add extraInitContainers #32245

Merged
merged 1 commit into from
May 1, 2024
Merged

install/kubernetes: add extraInitContainers #32245

merged 1 commit into from
May 1, 2024

Conversation

bewing
Copy link
Contributor

@bewing bewing commented Apr 30, 2024

allow additional initContainers to be added to cilium-agent Daemonset via helm values.

@bewing bewing requested review from a team as code owners April 30, 2024 01:10
@bewing bewing requested a review from squeed April 30, 2024 01:10
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 30, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Apr 30, 2024
@joestringer joestringer added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Apr 30, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 30, 2024
@joestringer
Copy link
Member

/test

@bewing
Copy link
Contributor Author

bewing commented Apr 30, 2024

fixed missing top-level documentation

@joestringer
Copy link
Member

/test

@squeed
Copy link
Contributor

squeed commented Apr 30, 2024

Looks good, but you will have to add initContainers to our spelling dictionary :-/. Sorry for the run-around.

@bewing bewing requested a review from a team as a code owner April 30, 2024 12:27
@bewing bewing requested a review from qmonnet April 30, 2024 12:27
@bewing
Copy link
Contributor Author

bewing commented Apr 30, 2024

New changeset after running Documentation/update-spelling_wordlist.sh initContainers

@joestringer
Copy link
Member

/test

qmonnet
qmonnet approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bewing
install/kubernetes: add extraInitContainers
5a671ed 
allow additional initContainers to be added to cilium-agent Daemonset
via helm values.

Signed-off-by: Brandon Ewing <brandon.ewing@imc.com>
@joestringer
Copy link
Member

/test

@joestringer joestringer enabled auto-merge May 1, 2024 16:40
@joestringer joestringer added this pull request to the merge queue May 1, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 1, 2024
Merged via the queue into cilium:main with commit 2a154a6 May 1, 2024
62 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bewing @joestringer @squeed @qmonnet