daemon: Do not require NodePort for WireGuard #32249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 6481b5b ("daemon: Detect bpf_host netdevs when WG is enabled") extended the disablement of NodePort. In particular, finishKubeProxyReplacementInit() does not disable NodePort if WG is enabled. This does not make any sense, as WG does not depend on NodePort, and bpf_host attachment (which WG depends on) is controlled via AreDevicesRequired(). Signed-off-by: Martynas Pumputis <m@lambda.lt>
Extend the E2E configurations to test for WG w/o KPR. Previously, we did not have any config to test it. Considering, that it can be a widely used configuration, sacrifice the 10th config (egress GW, endpoint routes, multi-netdev all are tested in other configs). Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added
area/daemon
|
/test |
nebril
approved these changes
Apr 30, 2024
aanm
approved these changes
Apr 30, 2024
tommyp1ckles
approved these changes
Apr 30, 2024
|
@brb The titles of PRs like this will end up in release notes, so as such it is preferable to fully expand any acronyms so that users can more easily understand the context of things like 'WG' here (or search through release notes if they're really interested in that particular feature). I'll update this one so it's clearer for the upcoming v1.16 release. |
joestringer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msgs. cc @tommyp1ckles