Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.13 Backports 2024-04-30 #32252

Merged
merged 12 commits into from
May 2, 2024
Merged

v1.13 Backports 2024-04-30 #32252

merged 12 commits into from
May 2, 2024

Commits on Apr 30, 2024

  1. Agent: add kubeconfigPath to initContainers

    [ upstream commit 284ee43 ]
    
    This commit adds the missing pass of
    the Helm value `kubeConfigPath` to the
    initContainer of the Cilium-agent.
    
    Signed-off-by: darox <maderdario@gmail.com>
    Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
    darox authored and gandro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a3ebee2 View commit details
    Browse the repository at this point in the history
  2. Remove aks-preview from AKS workflows

    [ upstream commit a758d21 ]
    
    Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
    Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
    marseel authored and gandro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f5be543 View commit details
    Browse the repository at this point in the history
  3. vendor: Bump cilium/dns to fix bug where timeout was not respected

    [ upstream commit c76677d ]
    
    This pulls in cilium/dns#11 which fixes a bug where the `SharedClient`
    logic did not respect the `c.Client.Timeout` field.
    
    Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
    gandro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ed51536 View commit details
    Browse the repository at this point in the history
  4. dnsproxy: Fix bug where DNS request timed out too soon

    [ upstream commit 931b816 ]
    
    This fixes a bug where DNS requests would timeout after 2 seconds,
    instead of the intended 10 seconds. This resulted in a `Timeout waiting
    for response to forwarded proxied DNS lookup` error message whenever the
    response took longer than 2 seconds.
    
    The `dns.Client` used by the proxy is [already configured][1] to use
    `ProxyForwardTimeout` value of 10 seconds, which would apply also to the
    `dns.Client.DialTimeout`, if it was not for the custom `net.Dialer` we
    use in Cilium. The logic in [dns.Client.getTimeoutForRequest][2]
    overwrites the request timeout with the timeout from the custom
    `Dialer`. Therefore, the intended `ProxyForwardTimeout` 10 second
    timeout value was overwritten with the much shorter `net.Dialer.Timeout`
    value of two seconds. This commit fixes that issue by using
    `ProxyForwardTimeout` for the `net.Dialer` too.
    
    Fixes: cf3cc16 ("fqdn: dnsproxy: fix forwarding of the original security identity for TCP")
    
    [1]: https://github.com/cilium/cilium/blob/50943dbc02496c42a4375947a988fc233417e163/pkg/fqdn/dnsproxy/proxy.go#L1042
    [2]: https://github.com/cilium/cilium/blob/94f6553f5b79383b561e8630bdf40bd824769ede/vendor/github.com/cilium/dns/client.go#L405
    
    Reported-by: Andrii Iuspin <andrii.iuspin@isovalent.com>
    Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
    gandro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ad47fda View commit details
    Browse the repository at this point in the history
  5. ipam: retry netlink.LinkList call when setting up ENI devices

    [ upstream commit cf9bde5 ]
    
    LinkList is prone to interrupts which are surfaced by the netlink library.  This leads to stability issues when using the ENI datapath.  This change makes it part of the retry loop in waitForNetlinkDevices.
    
    Fixes: #31974
    Signed-off-by: Jason Aliyetti <jaliyetti@gmail.com>
    Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
    jasonaliyetti authored and gandro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9811b11 View commit details
    Browse the repository at this point in the history
  6. workflows: Fix CI jobs for push events on private forks

    [ upstream commit 715906a ]
    
    Those workflows are failing to run on push events in private forks. They
    fail in the "Deduce required tests from code changes" in which we
    compute a diff of changes. To compute that diff, the dorny/paths-filter
    GitHub action needs to be able to checkout older git references.
    Unfortunately, we checkout only the latest reference and drop
    credentials afterwards.
    
    This commit fixes it by checking out the full repository. This will take
    a few seconds longer so probably not a big issue.
    
    Reported-by: Marco Iorio <marco.iorio@isovalent.com>
    Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
    Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
    pchaigno authored and gandro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    538e9df View commit details
    Browse the repository at this point in the history
  7. docs: Fix prometheus port regex

    [ upstream commit 49334a5 ]
    
    Signed-off-by: James Bodkin <james.bodkin@amphora.net>
    Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
    JBodkin-Amphora authored and gandro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b0cc560 View commit details
    Browse the repository at this point in the history
  8. endpoint: Skip build queue warning log is context is canceled

    [ upstream commit 8f0b106 ]
    
    The warning log on failure to queue endpoint build is most likely not
    meaningful when the context is canceled, as this typically happends when
    the endpoint is deleted.
    
    Skip the warning log if error is context.Canceled. This fixes CI flakes
    like this:
    
        Found 1 k8s-app=cilium logs matching list of errors that must be investigated:
        2024-04-22T07:48:47.779499679Z time="2024-04-22T07:48:47Z" level=warning msg="unable to queue endpoint build" ciliumEndpointName=kube-system/coredns-76f75df574-9k8sp containerID=3791acef13 containerInterface=eth0 datapathPolicyRevision=0 desiredPolicyRevision=0 endpointID=637 error="context canceled" identity=25283 ipv4=10.0.0.151 ipv6="fd02::82" k8sPodName=kube-system/coredns-76f75df574-9k8sp subsys=endpoint
    
    Fixes: #31827
    Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
    Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
    jrajahalme authored and gandro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    97b18e8 View commit details
    Browse the repository at this point in the history
  9. build(deps): bump pydantic from 2.3.0 to 2.7.1 in /Documentation

    [ upstream commit b971e46 ]
    
    Bumps [pydantic](https://github.com/pydantic/pydantic) from 2.3.0 to 2.4.0.
    - [Release notes](https://github.com/pydantic/pydantic/releases)
    - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md)
    - [Commits](pydantic/pydantic@v2.3.0...v2.4.0)
    
    [ Quentin: The pydantic update requires an update of pydantic_core, too.
        Bump both packages to their latest available version (pydantic 2.7.1
        and pydantic_core 2.18.2). ]
    
    ---
    updated-dependencies:
    - dependency-name: pydantic
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Signed-off-by: Quentin Monnet <qmo@qmon.net>
    Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
    dependabot[bot] authored and gandro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8f41565 View commit details
    Browse the repository at this point in the history
  10. ci: update docs-builder

    [ upstream commit 6e53ad7 ]
    
    Signed-off-by: Cilium Imagebot <noreply@cilium.io>
    Cilium Imagebot authored and gandro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    61c886d View commit details
    Browse the repository at this point in the history
  11. install/kubernetes: update nodeinit image to latest version

    [ upstream commit a206965 ]
    [ backporter notes: minor conflict in Makefile.values and regenerated docs ]
    
    For some reason the renovate configuration added in commit ac804b6
    ("install/kubernetes: use renovate to update
    quay.io/cilium/startup-script") did not pick up the update. Bump the
    image manually for now while we keep investigating.
    
    Signed-off-by: Tobias Klauser <tobias@cilium.io>
    tklauser authored and gandro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f594aa4 View commit details
    Browse the repository at this point in the history
  12. ci: Increase timeout for images for l4lb test

    [ upstream commit 8cea46d ]
    
    Followup for #27706
    
    Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
    Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
    marseel authored and gandro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    cdabcbb View commit details
    Browse the repository at this point in the history