test/helpers: Skip CiliumUninstall if not installed #32272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various tests will call UninstallCiliumFromManifest() ->
DeleteAndWait() during cleanup, including when the test itself gets
skipped. When running individual test cases from kind, this can mean
that the file that is supposed to contain the Cilium configuration
doesn't exist on the local filesystem, and then when attempting to
delete that Cilium configuration from the cluster, the tesuite reports:
K8sBandwidthTest Checks Bandwidth Rate-Limiting
at /home/joe/git/cilium/test/ginkgo-ext/scopes.go:527
[Error removing cilium from installed manifest
Expected
<*exec.ExitError | 0xc0003f2420>: exit status 1
to be nil]
Fix this by looking to see whether the file even exists. If we never
properly configured Cilium in the first place, then the file won't
exist, and then it's safe to just no-op the uninstall process.
Signed-off-by: Joe Stringer <joe@cilium.io>
|
/test |
christarazi
approved these changes
May 1, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various tests will call UninstallCiliumFromManifest() ->
DeleteAndWait() during cleanup, including when the test itself gets
skipped. When running individual test cases from kind, this can mean
that the file that is supposed to contain the Cilium configuration
doesn't exist on the local filesystem, and then when attempting to
delete that Cilium configuration from the cluster, the tesuite reports:
Fix this by looking to see whether the file even exists. If we never
properly configured Cilium in the first place, then the file won't
exist, and then it's safe to just no-op the uninstall process.