fqdn: Fix benchmarking for fqdn cache test #32276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
release-note/ci
joestringer
added
the
dont-merge/blocked
joestringer
force-pushed
the
pr/joe/fqdn-conn-timeouts
branch
2 times, most recently
from
4aedd54
to
795d80b
Compare
Rather than testing a number of iterations of the core update function
here, the test was varying the data input size. This was violating the
recommendations from the Go docs, which state:
The benchmark function must run the target code b.N times. During
benchmark execution, b.N is adjusted until the benchmark function
lasts long enough to be timed reliably.
This could lead to unreliable benchmarking numbers. Fix it.
Example run:
$ go test ./pkg/fqdn -bench BenchmarkFqdnCache
...
goos: linux
goarch: amd64
pkg: github.com/cilium/cilium/pkg/fqdn
cpu: 13th Gen Intel(R) Core(TM) i7-1365U
BenchmarkFqdnCache-12 100 110924076 ns/op
PASS
ok github.com/cilium/cilium/pkg/fqdn 11.505s
Suggested-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
pr/joe/fqdn-benchmark
branch
from
c377530
to
6fe0adf
Compare
joestringer
removed
the
dont-merge/blocked
|
/test |
|
btw this one may make sense to rebalance back to @pippolo84 since it was his suggestion, cc @doniacld |
pippolo84
approved these changes
May 13, 2024
There was a problem hiding this comment.
Thanks! 💯
I've also pushed a similar PR for BenchmarkNotifyOnDNSMsg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: #32013
Rather than testing a number of iterations of the core update function
here, the test was varying the data input size. This was violating the
recommendations from the Go docs, which state:
This could lead to unreliable benchmarking numbers. Fix it.
Example run: