Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Clean-up development setup #32277

Merged
merged 1 commit into from
May 1, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented May 1, 2024

Main points are as per below:

  • Remove cfssl and cfssljson as these tools are used for provisioning Vagrant dev cluster, which is un-maintained now.
  • Update versions in dev-tool for helm, kubectl, clang and gingko

Main points are as per below:

- Remove cfssl and cfssljson as these tools are used for provisioning
  Vagrant dev cluster,  which is un-maintained now.
- Update versions in dev-tool for helm, kubectl, clang and gingko

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 1, 2024
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label May 1, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 1, 2024
@sayboras sayboras marked this pull request as ready for review May 1, 2024 00:09
@sayboras sayboras requested review from a team as code owners May 1, 2024 00:09
@sayboras sayboras requested review from aditighag and qmonnet May 1, 2024 00:09
@sayboras
Copy link
Member Author

sayboras commented May 1, 2024

/test

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tam!

@qmonnet qmonnet removed the request for review from aditighag May 1, 2024 08:44
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 1, 2024
@sayboras sayboras added this pull request to the merge queue May 1, 2024
Merged via the queue into cilium:main with commit baec8dd May 1, 2024
65 checks passed
@sayboras sayboras deleted the pr/tammach/dev-requirement branch May 1, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants