Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/envoy: Replace gocheck with built-in go test #32280

Merged
merged 1 commit into from
May 2, 2024
Merged

pkg/envoy: Replace gocheck with built-in go test #32280

merged 1 commit into from
May 2, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented May 1, 2024

One point worth noting is the custom checker is migrated to assert.AssertComparision interface.

Relates: #28596

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 1, 2024
@sayboras sayboras added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels May 1, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 1, 2024
@sayboras
Copy link
Member Author

sayboras commented May 1, 2024

/ci-integration

@sayboras
Copy link
Member Author

sayboras commented May 1, 2024

/ci-runtime

@sayboras sayboras marked this pull request as ready for review May 1, 2024 09:29
@sayboras sayboras requested a review from a team as a code owner May 1, 2024 09:29
@sayboras sayboras requested a review from mhofstetter May 1, 2024 09:29
@sayboras
Copy link
Member Author

sayboras commented May 1, 2024

/test

mhofstetter
mhofstetter approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks Tam! 🥇 Only two nits.

pkg/envoy/embedded_envoy_test.go Outdated Show resolved Hide resolved
pkg/envoy/xds/node_test.go Outdated Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels May 2, 2024
@mhofstetter mhofstetter removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 2, 2024
@sayboras
pkg/envoy: Replace gocheck with built-in go test
bd6a559 
One point worth noting is the custom checker is migrated to
assert.AssertComparision interface.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
Copy link
Member Author

sayboras commented May 2, 2024

/test

@sayboras sayboras enabled auto-merge May 2, 2024 07:01
@sayboras sayboras added this pull request to the merge queue May 2, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 2, 2024
Merged via the queue into cilium:main with commit b2ff580 May 2, 2024
63 of 64 checks passed
@sayboras sayboras deleted the pr/tammach/gocheck-envoy branch May 2, 2024 08:44
sayboras added a commit that referenced this pull request May 7, 2024
@sayboras
xds: Replace gocheck with built-in go test
785416a 
This was missed in previous PR #32280

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request May 8, 2024
@sayboras
xds: Replace gocheck with built-in go test
acbe615 
This was missed in previous PR #32280

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request May 8, 2024
@sayboras
xds: Replace gocheck with built-in go test
d702384 
This was missed in previous PR #32280

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request May 9, 2024
@sayboras
xds: Replace gocheck with built-in go test
17a6bf7 
This was missed in previous PR #32280

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request May 10, 2024
@sayboras
xds: Replace gocheck with built-in go test
622a632 
This was missed in previous PR #32280

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request May 13, 2024
@sayboras
xds: Replace gocheck with built-in go test
074dbd0 
This was missed in previous PR #32280

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request May 14, 2024
@sayboras
xds: Replace gocheck with built-in go test
f91789f 
This was missed in previous PR #32280

Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot pushed a commit that referenced this pull request May 14, 2024
@sayboras
xds: Replace gocheck with built-in go test
b45e5e6 
This was missed in previous PR #32280

Signed-off-by: Tam Mach <tam.mach@cilium.io>
jshr-w pushed a commit to jshr-w/cilium that referenced this pull request May 16, 2024
@sayboras @jshr-w
xds: Replace gocheck with built-in go test
4c3a357 
This was missed in previous PR cilium#32280

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhofstetter mhofstetter mhofstetter approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sayboras @mhofstetter