Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lb: Replace gocheck with built-in go test #32282

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented May 1, 2024

Please refer to individual commits for more details, this PR is focusing on files owned by cilium/sig-lb team.

Relates: #28596

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 1, 2024
@sayboras sayboras changed the title fqdn: Replace gocheck with built-in go test lb: Replace gocheck with built-in go test May 1, 2024
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label May 1, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 1, 2024
@sayboras
Copy link
Member Author

sayboras commented May 1, 2024

/ci-runtime

@sayboras
Copy link
Member Author

sayboras commented May 1, 2024

/ci-integration

@sayboras sayboras marked this pull request as ready for review May 1, 2024 10:55
@sayboras sayboras requested a review from a team as a code owner May 1, 2024 10:55
@sayboras sayboras requested a review from ysksuzuki May 1, 2024 10:55
@sayboras
Copy link
Member Author

sayboras commented May 1, 2024

/test

@aditighag aditighag removed the request for review from ysksuzuki May 1, 2024 19:04
@aditighag aditighag added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 28747f6 May 1, 2024
276 of 279 checks passed
@aditighag aditighag deleted the pr/tammach/gocheck-lb branch May 1, 2024 19:12
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 1, 2024
sayboras added a commit that referenced this pull request May 7, 2024
This is the left over from #32282

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request May 8, 2024
This is the left over from #32282

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request May 8, 2024
This is the left over from #32282

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request May 9, 2024
This is the left over from #32282

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request May 10, 2024
This is the left over from #32282

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request May 13, 2024
This is the left over from #32282

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request May 14, 2024
This is the left over from #32282

Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot pushed a commit that referenced this pull request May 14, 2024
This is the left over from #32282

Signed-off-by: Tam Mach <tam.mach@cilium.io>
jshr-w pushed a commit to jshr-w/cilium that referenced this pull request May 16, 2024
This is the left over from cilium#32282

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants