-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install/kubernetes: allow extra helm resources #32293
Conversation
Commit 7d7153f does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Allow additional aribitrary k8s resources to be added to the helm chart via the values file. This allows extension of the existing chart in a way that allows for the extension to be tracked via helm installation history, making rollbacks to earlier state easier than the current case, which involves performing a helm install and then adding/editing additional resources manually. As an example use-case, you may wish to add additional ClusterRoles and ClusterRoleBindings to the cilium daemonset's service account to let an initContainer or sidecar container watch for LLDP traffic indicating a router, and configure CiliumBgpPeeringPolicies based on that data. Signed-off-by: Brandon Ewing <brandon.ewing@imc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for the PR! This is an interesting idea, however I'm personally a bit opposed to it because it seems like an anti-pattern. The Cilium helm chart is built to install Cilium in a way that gets it up and running. If there are other resources that a user needs to apply alongside Cilium for their specific use case, and wants to take advantage of Helm's deployment features, it's my opinion that they should create a separate helm chart to do so. For example, a chart could be defined that includes the resources for a specific use-case and then specifies Cilium as a dependency. I'm definitely curious as to what other folks think though.
This pull request has been automatically marked as stale because it |
This pull request has not seen any activity since it was marked stale. |
Allow additional aribitrary k8s resources to be added to the helm chart via the values file. This allows extension of the existing chart in a way that allows for the extension to be tracked via helm installation history, making rollbacks to earlier state easier than the current case, which involves performing a helm install and then adding/editing additional resources manually.
As an example use-case, you may wish to add additional ClusterRoles and ClusterRoleBindings to the cilium daemonset's service account to let an initContainer or sidecar container watch for LLDP traffic indicating a router, and configure CiliumBgpPeeringPolicies based on that data.