Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: hide dynamic/static variant for policy tail-call #32299

Merged

Conversation

julianwiedmann
Copy link
Member

Whether the tail-call is executed as dynamic or static is an implementation detail. Hide it in a generic tail_call_policy() helper.

Suggested-by: Timo Beckers timo@isovalent.com

Whether the tail-call is executed as dynamic or static is an implementation
detail. Hide it in a generic tail_call_policy() helper.

Suggested-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added sig/loader Impacts the loading of BPF programs into the kernel. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels May 2, 2024
@julianwiedmann julianwiedmann requested a review from ti-mo May 2, 2024 06:43
@julianwiedmann
Copy link
Member Author

@ti-mo is this what you had in mind for #32151 (comment) ?

@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review May 2, 2024 10:55
@julianwiedmann julianwiedmann requested a review from a team as a code owner May 2, 2024 10:55
@julianwiedmann julianwiedmann requested a review from jibi May 2, 2024 10:55
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 2, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue May 2, 2024
Merged via the queue into cilium:main with commit de55fd8 May 2, 2024
64 of 65 checks passed
@julianwiedmann julianwiedmann deleted the 1.16-bpf-tail-call-dynamic branch May 2, 2024 12:04
@julianwiedmann julianwiedmann added the backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. label May 9, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.15 in 1.15.5 May 9, 2024
@nebril nebril added this to Backport pending to v1.15 in 1.15.6 May 10, 2024
@nebril nebril removed this from Backport pending to v1.15 in 1.15.5 May 10, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. sig/loader Impacts the loading of BPF programs into the kernel.
Projects
1.15.6
Backport pending to v1.15
Development

Successfully merging this pull request may close these issues.

None yet

3 participants