-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "test: Disable hostfw in monitor aggregation test" #32315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
added
area/CI-improvement
Topic or proposal to improve the Continuous Integration workflow
release-note/ci
This PR makes changes to the CI.
area/host-firewall
Impacts the host firewall or the host endpoint.
labels
May 2, 2024
/test |
qmonnet
added
the
ci/host-firewall
This label enables the host firewall by default in all CI tests.
label
May 2, 2024
/ci-ginkgo |
qmonnet
removed
the
ci/host-firewall
This label enables the host firewall by default in all CI tests.
label
May 2, 2024
The label |
/ci-ginkgo |
qmonnet
added
the
dont-merge/preview-only
Only for preview or testing, don't merge it.
label
May 2, 2024
This reverts commit 7a1a76e. The complexity issue occurred on kernel 4.19, which is no longer supported. We closed cilium#14552 and we can now have the Host Firewall, monitorAggregation=medium and monitorFlags=syn together. Signed-off-by: Quentin Monnet <qmo@qmon.net>
qmonnet
removed
the
dont-merge/preview-only
Only for preview or testing, don't merge it.
label
May 2, 2024
/test |
tklauser
approved these changes
May 2, 2024
julianwiedmann
approved these changes
May 2, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI-improvement
Topic or proposal to improve the Continuous Integration workflow
area/host-firewall
Impacts the host firewall or the host endpoint.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7a1a76e.
The complexity issue occurred on kernel 4.19, which is no longer supported. We closed #14552 and we can now have the Host Firewall,
monitorAggregation=medium
andmonitorFlags=syn
together.