Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "test: Disable hostfw in monitor aggregation test" #32315

Merged
merged 1 commit into from
May 2, 2024

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented May 2, 2024

This reverts commit 7a1a76e.

The complexity issue occurred on kernel 4.19, which is no longer supported. We closed #14552 and we can now have the Host Firewall, monitorAggregation=medium and monitorFlags=syn together.

@qmonnet qmonnet added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. area/host-firewall Impacts the host firewall or the host endpoint. labels May 2, 2024
@qmonnet
Copy link
Member Author

qmonnet commented May 2, 2024

/test

@qmonnet qmonnet marked this pull request as ready for review May 2, 2024 14:56
@qmonnet qmonnet requested review from a team as code owners May 2, 2024 14:56
@qmonnet qmonnet requested a review from tklauser May 2, 2024 14:56
@qmonnet qmonnet added the ci/host-firewall This label enables the host firewall by default in all CI tests. label May 2, 2024
@qmonnet qmonnet marked this pull request as draft May 2, 2024 14:59
@qmonnet
Copy link
Member Author

qmonnet commented May 2, 2024

/ci-ginkgo

@qmonnet qmonnet removed the ci/host-firewall This label enables the host firewall by default in all CI tests. label May 2, 2024
@qmonnet
Copy link
Member Author

qmonnet commented May 2, 2024

The label ci/host-firewall stopped working when we switched from Jenkins, I'll need a test commit to enable the host firewall manually (although given that we no longer have a way to run this check with the host firewall enabled, the PR is obviously OK in itself).

@qmonnet
Copy link
Member Author

qmonnet commented May 2, 2024

/ci-ginkgo

@qmonnet qmonnet added the dont-merge/preview-only Only for preview or testing, don't merge it. label May 2, 2024
@qmonnet
Copy link
Member Author

qmonnet commented May 2, 2024

So I enforced the use of the Host Firewall:

image

... and it passed!

image

We're good, I'll remove the test commit.

This reverts commit 7a1a76e.

The complexity issue occurred on kernel 4.19, which is no longer
supported. We closed cilium#14552 and
we can now have the Host Firewall, monitorAggregation=medium and
monitorFlags=syn together.

Signed-off-by: Quentin Monnet <qmo@qmon.net>
@qmonnet qmonnet removed the dont-merge/preview-only Only for preview or testing, don't merge it. label May 2, 2024
@qmonnet qmonnet marked this pull request as ready for review May 2, 2024 16:00
@qmonnet
Copy link
Member Author

qmonnet commented May 2, 2024

/test

@julianwiedmann julianwiedmann added this pull request to the merge queue May 2, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 2, 2024
Merged via the queue into cilium:main with commit 8c9e022 May 2, 2024
61 checks passed
@qmonnet qmonnet deleted the pr/monagg-hfw branch May 7, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow area/host-firewall Impacts the host firewall or the host endpoint. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complexity issue on 4.19 with host firewall, monitorAggregation=medium and monitorFlags=syn
3 participants