contrib: Remove CHARTS_PATH dependency #32328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script would check for CHARTS_PATH and CHARTS_TOOL, but it never actually invoked them. We've renamed the script now so it's out of date. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
the
release-note/misc
michi-covalent
approved these changes
May 2, 2024
nebril
added
needs-backport/1.13
|
Marking for backporting since I hit this while doing current releases. |
|
@nebril I'd highly suggest using the scripts from Personally the way I manage those is to use git worktrees, ie multiple local dirs for different branches and then run the copy from |
yeah i think this makes sense, maybe we just need to improve the release check list. i always get confused from which branch i'm running what command 😵 |
15 tasks
YutaroHayakawa
added
backport-pending/1.15
12 tasks
YutaroHayakawa
added
backport-pending/1.14
10 tasks
YutaroHayakawa
added
backport-pending/1.13
github-actions
bot
added
backport-done/1.15
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script would check for CHARTS_PATH and CHARTS_TOOL, but it never
actually invoked them. We've renamed the script now so it's out of date.
Remove the check altogether, we can automate running the Helm bits later.
Related: cilium/charts#114