Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tables: Fix slice indexing in nodeAddressController #32506

Merged
merged 1 commit into from
May 16, 2024
Merged

tables: Fix slice indexing in nodeAddressController #32506

merged 1 commit into from
May 16, 2024

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented May 13, 2024 •
edited
Loading

The index used for ipv4PrivateIndex/ipv4PublicIndex was wrong in cases where the address was skipped. Use the proper index to which the address is appended.

Fix indexing bug in the logic for picking NodePort addresses. In rare cases this may have caused wrong address to be selected for NodePort use, or an out-of-bounds access.

@joamaki joamaki added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels May 13, 2024
@joamaki joamaki requested a review from a team as a code owner May 13, 2024 11:10
@joamaki joamaki requested a review from ldelossa May 13, 2024 11:10
@joamaki
Copy link
Contributor Author

joamaki commented May 13, 2024

/test

@joamaki joamaki enabled auto-merge May 15, 2024 11:56
@joamaki
tables: Fix slice indexing in nodeAddressController
b70dba7 
The index used for ipv4PrivateIndex/ipv4PublicIndex was wrong in cases
where the address was skipped. Use the proper index to which the address
is appended.

Fixes: 7da6514 ("tables: Sort node addresses also by public vs private IP")
Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki force-pushed the pr/joamaki/fix-node-address-indexing branch from 224990a to b70dba7 Compare May 15, 2024 12:48
@joamaki
Copy link
Contributor Author

joamaki commented May 15, 2024

/test

@joamaki joamaki added this pull request to the merge queue May 16, 2024
Merged via the queue into cilium:main with commit 2b31c34 May 16, 2024
63 of 64 checks passed
@joamaki joamaki deleted the pr/joamaki/fix-node-address-indexing branch May 16, 2024 15:16
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 23, 2024
Merged
15 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels May 23, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels May 25, 2024
@michi-covalent michi-covalent mentioned this pull request Jun 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandreimerink dylandreimerink dylandreimerink approved these changes

@ldelossa ldelossa Awaiting requested review from ldelossa ldelossa is a code owner automatically assigned from cilium/sig-datapath

Assignees
No one assigned
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
cilium v1.15.6
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joamaki @dylandreimerink @YutaroHayakawa