pkg/cgroups: Cache pod metadata on datapath events #32615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
1 task
aditighag
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
aditighag
force-pushed
the
pr/aditighag/cache-cgroup-metadata
branch
2 times, most recently
from
5fdb0ae
to
d6b947f
Compare
sayboras
reviewed
May 18, 2024
joestringer
reviewed
May 21, 2024
aditighag
force-pushed
the
pr/aditighag/cache-cgroup-metadata
branch
from
d6b947f
to
c5c4ec9
Compare
aditighag
force-pushed
the
pr/aditighag/cache-cgroup-metadata
branch
from
c5c4ec9
to
da60744
Compare
|
/ci-runtime |
joestringer
reviewed
May 23, 2024
There was a problem hiding this comment.
Some minor further comments on the use of WaitGroups for synchronizing the unit tests - The usage doesn't seem to match canonical Go usage, and doesn't match up with the API comments in the library package. Fixing that up by passing it as a parameter or switching to channels should be a simple change though AFAICT.
The test case fails without the setup when run by itself. Fixes: 92ea5a1 ("pkg/cgroups: Replace gocheck with built-in go test") Signed-off-by: Aditi Ghag <aditi@cilium.io>
Signed-off-by: Aditi Ghag <aditi@cilium.io>
aditighag
force-pushed
the
pr/aditighag/cache-cgroup-metadata
branch
from
da60744
to
b99accf
Compare
|
/ci-runtime |
aditighag
force-pushed
the
pr/aditighag/cache-cgroup-metadata
branch
from
b99accf
to
be4655d
Compare
|
/ci-runtime |
joestringer
approved these changes
May 24, 2024
Cgroup manager events were previously synchronized via a channel. However, Hubble calls GetPodMetadataForContainer on datapath socket tracing events that can be generated much more frequently than control plane events. Add a cache for the datapath read events in order to reduce the overhead associated with channel events processing. This would mean that the datapath events may get data via cache while any pod delete events are in progress. Since only the control plane events are required to be synchronized, it's acceptable that datapath tracing events may see cached data for a short duration. Benchmark results: Before: BenchmarkGetPodMetadataForContainer-14 848550 1383 ns/op After: BenchmarkGetPodMetadataForContainer-14 2885898 408.7 ns/op Reported-by: Joe Stringer <joe@cilium.io> Signed-off-by: Aditi Ghag <aditi@cilium.io>
aditighag
force-pushed
the
pr/aditighag/cache-cgroup-metadata
branch
from
be4655d
to
c730e61
Compare
|
/ci-runtime |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits description.